Revert "simple-tooltip RTL support made optional" #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
If you are willing to work on that feature and open an issue https://github.com/haxtheweb/issues/issues/new that sounds like a worthy feature around pillar A11y https://haxtheweb.org/community/pillars/accessibility in the name of i18n. We have an i18n mixin that helps with translation json blobs but what you are describing probably would be best as a stand alone mix-in (potentially) that's providing consistent behavior in a similar way that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #713
@btopro Really sorry but this change is not needed. Some change in our code led me to believe it was so please revert this. Turns out some forms of containment cause overflow problems and I thought it was the tooltip's fault and it's not. Sorry again.
One thing I would propose is do you want to add position="start" and "end" which will be automatically set to left or right based on the direction of the top level document. This feature does seem to be needed to provide a more seamless experience. Let me know what you think.